fix(web): focus the primary action when confirmation dialogs open - #18187

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: eb2d1a97-60ea-4138-a22a-52ba5f8342c0

📥 Commits

Reviewing files that changed from the base of the PR and between 894463f and 6f46e56.

📒 Files selected for processing (10)

• apps/web/src/components/ConfirmDialogHost.test.tsx
• apps/web/src/components/ConfirmDialogHost.tsx
• apps/web/src/components/LegacySidebar.tsx
• apps/web/src/components/ServerUpdateAction.tsx
• apps/web/src/components/settings/SettingsPanels.tsx
• apps/web/src/components/sidebar/SidebarUpdatePill.tsx
• apps/web/src/components/ui/dialog.test.tsx
• apps/web/src/components/ui/dialog.tsx
• apps/web/src/confirmDialog.ts
• packages/contracts/src/ipc.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Dialog components now support initial-focus options for confirmation dialogs. They focus eligible actions when a dialog opens. Several confirmation callers request focus on Confirm.

Changes: Dialog Initial Focus

Layer / File(s)	Summary
Carry confirmation focus options packages/contracts/src/ipc.ts, apps/web/src/confirmDialog.ts	ConfirmDialogOptions adds "confirm" and "cancel" focus choices. Active, queued, and closing confirmation states preserve the selected option.
Select dialog initial focus apps/web/src/components/ui/dialog.tsx, apps/web/src/components/ui/alert-dialog.tsx, apps/web/src/components/ui/dialog.test.tsx	Dialog popups select an enabled marked action for initial focus, or the popup on touch opens. Alert dialogs connect the focus hook and export AlertDialogAction. Tests cover default, disabled, and caller-provided focus targets.
Apply focus-aware confirmation actions apps/web/src/components/ConfirmDialogHost.tsx, apps/web/src/components/ConfirmDialogHost.test.tsx, apps/web/src/components/LegacySidebar.tsx, apps/web/src/components/ServerUpdateAction.tsx, apps/web/src/components/settings/SettingsPanels.tsx, apps/web/src/components/sidebar/SidebarUpdatePill.tsx, apps/web/src/components/cloud/RelayClientInstallDialog.tsx, apps/web/src/components/settings/BrowserImportWizard.tsx	Update confirmation callers request focus on Confirm. ConfirmDialogHost uses AlertDialogAction for eligible confirmations. Relay install and browser import actions use DialogAction. Tests cover default, requested, and destructive confirmation focus.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix · Severity of issue fixed: Low

Sequence Diagram(s)

sequenceDiagram
  participant ConfirmCaller
  participant ConfirmDialogState
  participant ConfirmDialogHost
  participant DialogPopup
  ConfirmCaller->>ConfirmDialogState: Set initialFocus option
  ConfirmDialogState->>ConfirmDialogHost: Publish confirmation state
  ConfirmDialogHost->>DialogPopup: Render focus-aware action
  DialogPopup->>DialogPopup: Focus eligible action on open

Loading

Suggested reviewers: juliusmarminge

This change focuses Confirm when update-confirmation dialogs open, and other confirmations keep Cancel focused by default. No concrete merge-blocking issue was found, and the worst case is a minor focus inconsistency.

Security architecture risk: 🔵 Low · up to 6f46e

The change selects an initial focus target rather than granting new permissions or removing confirmation. Ordinary and destructive confirmations retain Cancel unless an eligible action explicitly opts in. No security bypass was established in the inspected flows, but external-caller and runtime coverage remains incomplete.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The most consequential inspected focus change reaches confirmations for selected remote desktop machines, including a batch-update path. Their existing target selection and confirmation remain in place; the PR changes the keyboard-default choice rather than introducing additional execution targets. Broader tenant or deployment exposure was not established.

Trust Boundaries and Controls

• observed — The inspected MCP approval bridge passes only a message to requestConfirmDialog, not focus options. ConfirmDialogHost renders message-derived content as text and marks Confirm only when the state explicitly requests it and the variant is default. This path therefore retains its previous Cancel-first approval behavior.
• observed — Shared action selection excludes natively disabled elements. Destructive-action exclusion in DialogAction is a compile-time contract, whereas ConfirmDialogHost also enforces a runtime default-variant condition. These are focus-selection safeguards, not substitutes for operation authorization.

Resilience and Maintainability Implications

• observed — The confirmation transition assessment found focus metadata preserved across active, closing, and queued states without changing response ownership or cleanup. The inspected relay confirmation handler requires a confirming state and a live resolver, clears that resolver before resolution, and rejects overlapping installation requests.

Pre-merge checks: 3 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The description thoroughly explains the problem, implementation, verification, screenshots, recording, limitations, and agent details. However, it does not provide the required Scope and approval info…	Add a Scope and approval section. Link the triaged issue or maintainer discussion, include explicit approval of the direction and scope, or explain why this focused fix qualifies for an approval exemption.

Passed checks: 3 passed

Check name	Status	Explanation
Linked Issues check		Issue [#18167] now defines targeted scope for desktop and server update prompts, relay client install, and browser import "quit" and "try again" steps. The PR applies initialFocus to those call site…
Out of Scope Changes check		The dialog focus hook, DialogAction, ConfirmDialogHost option, contract plumbing, targeted call-site changes, and tests support [#18167]. The default Cancel focus for shared confirmations and dest…
Title check		The title clearly and concisely describes the primary change: focusing the primary action when confirmation dialogs open.

Full details: Linked Issues check

Explanation

Issue [#18167] now defines targeted scope for desktop and server update prompts, relay client install, and browser import "quit" and "try again" steps. The PR applies initialFocus to those call sites and implements DialogAction in the Dialog and AlertDialog primitives. The shared host remains Cancel-first by default and supports explicit confirm focus. Destructive confirms remain Cancel-first. Reported tests cover primary focus, disabled Confirm, caller overrides, host defaults, opt-in focus, and destructive opt-in behavior.

Full details: Out of Scope Changes check

Explanation

The dialog focus hook, DialogAction, ConfirmDialogHost option, contract plumbing, targeted call-site changes, and tests support [#18167]. The default Cancel focus for shared confirmations and destructive confirmations is an intentional safety behavior within the issue scope. No unrelated change is demonstrated.

Full details: Description check

Explanation

The description thoroughly explains the problem, implementation, verification, screenshots, recording, limitations, and agent details. However, it does not provide the required Scope and approval information, such as a triaged issue or explicit maintainer approval of the direction and scope.

Resolution

Add a Scope and approval section. Link the triaged issue or maintainer discussion, include explicit approval of the direction and scope, or explain why this focused fix qualifies for an approval exemption.

🧪 Generate unit tests (beta)

• Create a new PR

Running Pre-merge checks. Results will be posted in the summary comment once complete.